[Webkit-unassigned] [Bug 22713] New: Confusing/repetive onboard unicode sources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22713

           Summary: Confusing/repetive onboard unicode sources
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dmacks at netspace.org


Building r39007 on OS X 10.4 with fink installed for gtk dependencies, I
noticed during autogen:

checking the Unicode backend to use... icu

and then during compiling, flags for internal icu sources are passed
(-I./JavaScriptCore/icu -I./WebCore/icu). Now wait, I have libicu headers and a
"libicu-config" available on my system, why is webkit using what sounds like
*its own* icu lib? Looking at configure.ac, I see why, at line 237:

>if test "$os_darwin" = "yes"; then
>	UNICODE_CFLAGS="-I\$(srcdir)/JavaScriptCore/icu -I\$(srcdir)/WebCore/icu"
>	UNICODE_LIBS="-licucore"
[...]
>else
>	AC_PATH_PROG(icu_config, icu-config, no)
[...]
>	UNICODE_CFLAGS=`$icu_config --cppflags`
>	UNICODE_LIBS=`$icu_config --ldflags`
>fi

It hardcodes to use the internal one on darwin even if there is an actual
("normal for unixish platforms":) libicu available. Seems like the primary test
should be for availablity of icu-config, and then only fall back on
platform-dependent guessing if it's not found.

Secondarily, while looking at the included libicu, I see three different sets
of libicu headers in the webkit sources: JavaScriptCore/icu,
JavaScriptGlue/icu, and WebCore/icu, all annotated that they are for OS X 10.4.
So first, that's hella-redundant:) Can't all the components share *one* libicu?
But also, it's not consistent with configure.ac, which appears to trigger their
use on *all* OS X versions.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.