[Webkit-unassigned] [Bug 22586] Remove FontDatabase from Cairo Build of WebKit (Windows)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22586


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25658|review?                     |review-
               Flag|                            |




------- Comment #3 from aroben at apple.com  2008-12-01 22:12 PDT -------
(From update of attachment 25658)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 38852)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,15 @@
> +2008-11-30  Brent Fulgham  <bfulgham at gmail.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=22586
> +        Remove FontDatabase files from Cairo Windows build. 

Maybe you should make the name of the bug more general since you're making
other fixes in this change.

> +    static Color focusRingColor;
> +
> +    if (!focusRingColor.isValid())
> +        focusRingColor = aquaFocusRingColor;

You can do this all in one statement:

static Color focusRingColor = aquaFocusRingColor;

> +    void populateFontDatabase() { /* Do nothing */ }

Why not just add this one stub to platform/win/TemporaryLinkStubs.cpp?

r- because I don't think it's good to add another link stub file with a
different name that's only for Cairo (at least not if the name doesn't indicate
it's only for Cairo).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.