[Webkit-unassigned] [Bug 16171] [CAIRO] Canvas does not support globalAlpha

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16171


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23090|review?                     |review-
               Flag|                            |




------- Comment #7 from sam at webkit.org  2008-08-31 19:23 PDT -------
(From update of attachment 23090)
+static inline void setColor(cairo_t* cr, const Color& col, float globalAlpha)
Perhaps globalAlpha should default to 1.0f so that lines like 
+    setColor(cr, col, 1);
don't have to change. 

+    if (globalAlpha <= 0.999)
+        alpha *= globalAlpha;

Why not just if (globalAlpha < 1.0) ?

+        if (m_data->globalAlpha <= 0.999) {

same question.

+        :  cr(0),
+        globalAlpha(1)

This should read as
    GraphicsContextPlatformPrivate()
        : cr(0),
        , globalAlpha(1.0f)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.