[Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16401





------- Comment #19 from lkcl at lkcl.net  2008-08-31 17:19 PDT -------
review comments - kept here so as not to lose them, TBD tomorrow:

lkcl: and you appear to have slipped some tabs in to the patch along the way
;-)

WebKit/gtk/webkit/EventListenerWindow.h -- is that an API header?
API headers cannot do that

privgdomEventTargetNode.h would make more sense with the suffix of Private,
like is done with other private headers

why the lower-case prefix on the file names?  that doesn't fit our style
guidelines

you also appear to use GDOM and Gdom... consistencey would be good


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.