[Webkit-unassigned] [Bug 20577] REGRESSION (r35006): Gmail is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20577


cwzwarich at uwaterloo.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |cwzwarich at uwaterloo.ca
                   |unassigned at lists.webkit.org |




------- Comment #6 from cwzwarich at uwaterloo.ca  2008-08-31 13:58 PDT -------
The problem is basically that stringProtoFuncSubstr() was written to do its
index calculations for the UString::substr() method, which, like the JS
function substr, ignores lengths that are too long. Just plugging in
jsSubstring doesn't quite work unless the index computations are changed to
never overflow the length of the string. I'll assign this to myself, because
Darin is probably with his family.

There are similar replacements of UString::substr() with jsSubstring()
throughout Darin's patch, so after this is fixed it might be a good idea to go
through and check that all of them won't fall prey to the same problem in
unusual situations.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.