[Webkit-unassigned] [Bug 17897] Not Rendering Images Imported from XHTML Document

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 28 13:24:59 PDT 2008


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #23003|review?                     |review-
               Flag|                            |

------- Comment #9 from eric at webkit.org  2008-08-28 13:24 PDT -------
(From update of attachment 23003)
I'm still slightly concerned by this patch as it might break existing callers
of updateFromElement(), or future callers who don't know about this "don't do
anything if I've ever seen an error" behavior.  One way to address that would
be to have updateFromElement take a flag which was used to trigger this kind of
clear.  Another would be to ASSERT in updateElement that the current source was
the same as the previous source, or simply to only not re-try in
updateFromElement when the current source was the same and there was already an
error.  Another way would be to just give updateFromElement a better name! (the
current one is bad because it's so generic)

Hum... I just still think we can make this API clearer.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list