[Webkit-unassigned] [Bug 19528] [GTK] BackForward history leak?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19528


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22678|review?                     |review-
               Flag|                            |




------- Comment #3 from eric at webkit.org  2008-08-27 16:44 PDT -------
(From update of attachment 22678)
I would encourage you to read:
http://webkit.org/coding/RefPtr.html

Methods shouldn't return RefPtr.  Possibly "const RefPtr&" , but in that case
"Class*" is almost always better.

We also don't keep PassRefPtrs on the stack.  If you need more clarification
about RefPtr design, I encourage you to read that document or ask in #webkit. 
(or read some of hte other gtk bugs I've recently reviewed).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.