[Webkit-unassigned] [Bug 20013] Windows AX heuristics are poor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20013





------- Comment #80 from jhoneycutt at apple.com  2008-08-26 20:08 PDT -------
(From update of attachment 23006)
+    if (isLink() || isHeading()) {

I tested this in Firefox 3:
<h1>heading <div>div</div></h1>
<a>anchor <div>div</div></a>

The anchor's title was "anchor div" which matches the new results from your
patch, but the heading was nameless, so it seems that Firefox doesn't use this
same method with a heading. I think the isHeading() check should be moved back
where it was before this patch, and the layout tests for headings should be
removed.

+            append(elementText, childrenVector[i]->title());

This doesn't match what Firefox 3 does with:

<a title="title">text</a>

In WebKit, the name would appear as "title", but in Firefox the name would be
"text". I think you should use textUnderElement() instead of title().

Although this helps us to match Firefox, this patch breaks some of the current
layout tests on the Mac. I'm going to ask one of our Mac engineers to look at
this. It may be necessary to have different behavior for Mac and Windows.

r- for the above issues. Thanks for the patch!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.