[Webkit-unassigned] [Bug 19392] [Gtk] Enable WebInspector in the Gtk port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19392





------- Comment #22 from gns at gnome.org  2008-08-26 19:30 PDT -------
(In reply to comment #21)
> GtkObject, and therefore every GtkWidget, has a "destroy" signal with that same
> signature, that means "the object is disposed, with no way to stop that". But
> this signal merely means "finished" and it's still possible to keep a reference
> of the instance.
> I suggest the signal should have a different name to avoid confusion about how
> this signal works.

I renamed it "finished". I hope this works better =).

> No documentation at all here... Please add that.

I added documentation, with Since tags.

> And, would it be a good idea to allow _set_web_view with a NULL web_view to
> unset the web view?

Not really. The web view creation process is related to the
InspectorClient::createPage delegate, which is translated to the
inspect-web-view signal; The view can only be sanely set there, as far as I
know.

Just finishing up the patch.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.