[Webkit-unassigned] [Bug 19578] [CURL] problem in parseDataUrl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19578


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22956|review?                     |review-
               Flag|                            |




------- Comment #15 from eric at webkit.org  2008-08-25 21:01 PDT -------
(From update of attachment 22956)
I know Darin r+'d the old one, but I think this patch still could use one more
round.

The changelog contains tabs.  I still see no reason why the USE_GLIB_BASE64
path needs to exist.  I suggest we remove it.  r- for the tabs in the changelog
and lack of explanation as to why we should keep the USE_GLIB_BASE64 path.

Otherwise the patch looks fine.  Thanks again!  I look forward to seeing the
final patch.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.