[Webkit-unassigned] [Bug 17897] Not Rendering Images Imported from XHTML Document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17897


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22964|review?                     |review-
               Flag|                            |




------- Comment #6 from eric at webkit.org  2008-08-25 20:55 PDT -------
(From update of attachment 22964)
So are new HTMLImageLoader objects created every time a load is issued? 
Otherwise I fear your patch will break things like:

image.src = "willfail.png"
// first load returns an error, possibly from the error callback we do:
image.src = "willwork.png"

Also, I'm not a big fan of functions being declared in the middle of function
calls:

 26                 icon.addEventListener("load", function () {
 27                     var console = document.getElementById('console');
 28                     // If the image was loaded correctly, then height and
width are not
 29                     // zero.
 30                     if (icon.height && icon.width)
 31                         console.innerHTML = "PASSED";
 32                     else
 33                         console.innerHTML = "FAILED";
 34 
 35                     if (window.layoutTestController)
 36                         layoutTestController.notifyDone();
 37 
 38                 }, true);

I'd rather see that declared in a local variable and used instead of as part of
that function call.

Marking r- for now.  If you are convinced that the "load works after error
case" is OK (i.e. that we already have a test case which checks that and it
passes), then you can go ahead and land this.  Otherwise we'll need a test case
to prove that the "load a new url after the first one fails" case works.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.