[Webkit-unassigned] [Bug 19578] [CURL] problem in parseDataUrl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19578


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22937|review?                     |review+
               Flag|                            |




------- Comment #13 from darin at apple.com  2008-08-22 10:57 PDT -------
(From update of attachment 22937)
+        fix the String conversion on base64 data in parseDataUrl

This is a kind of vague description of what's being changed. And it doesn't
contain a bugs.webkit.org URL; it should.

+        WARNING: NO TEST CASES ADDED OR CHANGED

That should have been removed from the ChangeLog.

+        * platform/network/curl/ResourceHandleManager.cpp:
+        (WebCore::parseDataUrl):

It's better if the ChangeLog actually says what the change is.

The ifdefs in this function are kind of strange. Some of the code using outData
and out is inside #ifdefs and others are outside and unconditional. It would be
much better to be consistent.

But I'll say r=me, as-is


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.