[Webkit-unassigned] [Bug 19578] [CURL] problem in parseDataUrl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19578





------- Comment #10 from mbensi at pleyo.com  2008-08-22 02:45 PDT -------
(In reply to comment #9)
> (From update of attachment 22771 [edit])
> Please use a Vector<char> instead of using manual memory management.
> 
> Even OwnPtr would be better than manual use of fastFree.
> 
> Also, else should be on the same line as your }
> 
> In fact!  out is already a Vector<char>!! So you're just making a needless copy
> here. :(
> 
> Please move the Vector<char> out declaration outside of the if block.  And
> heck, just remove the USE_GLIB_BASE64 path, there is no reason to use
> g_base64_decode even if it's available.  Just remove the g_base64_decode
> codepath entirely.
> 

I was my first test (move the Vector<char> out declaration outside of the if
block) but the result is not good, i don't see google image...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.