[Webkit-unassigned] [Bug 20065] Remove UChar* accessors from StringImpl

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 21 17:51:13 PDT 2008


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #22340|review?(darin at apple.com)    |review+
               Flag|                            |

------- Comment #2 from darin at apple.com  2008-08-21 17:51 PDT -------
(From update of attachment 22340)
These changes are OK, but I don't think they really free us up to change the
implementation. There are clients of String::characters() and for good reason.

 102     // String::append and insert are extremely in-efficient, if you're
doing many
 103     // appends and inserts, consider using a Vector<UChar> or

inefficient doesn't have a "-" in it.

SegmentedString has an "n" in it.

 162     m_impl = m_impl->insert(charactersToInsert, lengthToInsert, position);

Why did you remove the ASSERT(m_impl) from this function?

I noticed that StringImpl::append(StringImpl*) does not optimize the
zero-length case. The old code didn't either, but that's not good.

I also think it's a bit strange to use codePointAt everywhere instead of the []


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list