[Webkit-unassigned] [Bug 18703] changing the 'size' property on a text input does not affect its length

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18703


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22923|review?                     |review-
               Flag|                            |




------- Comment #7 from darin at apple.com  2008-08-21 17:41 PDT -------
(From update of attachment 22923)
This is the wrong place to make a change. The setSize function is a helper
function that calls setAttribute, but the same bug can happen if you call
setAttribute directly; you can do that from JavaScript. Just change the line in
your test from:

    document.getElementById('success').size=30;

to:

    document.getElementById('success').setAttribute("size", 30);

The code that always runs when sizeAttr is changed is in
HTMLInputElement::parseMappedAttribute, so if we need to do more work, it would
be there.

I think a direct call to setNeedsLayoutAndPrefWidthsRecalc on the renderer is
not correct. It may be as simple as calling setChanged. We should look at other
attributes that don't work via CSS but can affect the layout to find the right
pattern. I wasn't able to think of one right away -- maybe Hyatt can.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.