[Webkit-unassigned] [Bug 15360] color:#{predefined colorName} is okay in Safari

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=15360


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22925|review?                     |review+
               Flag|                            |




------- Comment #8 from eric at webkit.org  2008-08-21 16:18 PDT -------
(From update of attachment 22925)
The change looks fine.  The test could still be "better"

<p id="test" style="color:#red">FAIL - testing that #color is ignored as a
color name, bug 15360</p>
<script>
if (window.layoutTestController)
   layoutTestController.dumpAsText();
var test = document.getElementById("test");
if (window.getComputedStyle(test).color == "rgb(0,0,0)") {
    test.innerText = "PASS";
}
</script>

would be more concise.  and shows only PASS/FAIL (to make it hopefully easier
to understand at a glance.

Even better would be to use a .js test, but that's a bit trickier for your
first patch (due to our lack of documentation on the subject, fast/js/resources
has a bunch of examples, make-js-test-wrappers is the script which generates
the .html files to run the .js tests from the TEMPLATE.html files).  We'll talk
about .js tests some time over IRC. :)

This is fine to land as-is though.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.