[Webkit-unassigned] [Bug 20466] Editing a property without quotes should add them if possible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20466


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22902|review?(timothy at hatcher.name|review-
               Flag|)                           |




------- Comment #2 from timothy at hatcher.name  2008-08-20 15:26 PDT -------
(From update of attachment 22902)
+            var result =
WebInspector.panels.scripts.evaluateInSelectedCallFrame(expression, false);
+        else
+            var result =
InspectorController.inspectedWindow().eval(expression);
+        return result;

no need to store in a variable, just return in the two places.

+            var result = this.evaluateExpression("(" + expression + ")");
             // Store the result in the property.
             this.parentObject[this.propertyName] = result;

Put a empty line between the var result and the comment.

+                var result = this.evaluateExpression('"' + expression + '"');
+                // Store the result in the property.
+                this.parentObject[this.propertyName] = result;

You should escape double quotes in the expression, otherwise it will fail
unexpectedly. Also put a empty line between the var result and the comment.

r- for now until the string is escaped. Just do
expression.escapeCharacters("\"");


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.