[Webkit-unassigned] [Bug 20422] Patch to allow custom memory allocation control

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20422





------- Comment #6 from mrowe at apple.com  2008-08-19 21:55 PDT -------
(In reply to comment #5)
> I can convert these to patches and make new attachments for that (along with a
> ChangeLog entry). Before I submitted the above files I walked over the coding
> guidelines and did any changes to make the code compliant. Did I possibly miss
> something?

There are a few issues that I see:
* Lack of license header
* Inconsistent placement of the opening brace in a function definition.
* Functions named with an initial upper-case letter.
* Use of C-style casts in C++ code.
* Use of NULL in C++ code.
* "Filled" block header comments.
* Large numbers of blank lines, such as at the end of the file.

Some of these aren't explicitly mentioned in the coding style guidelines, but
are style rules that we apply consistently throughout WebKit.  If something
isn't explicitly mentioned it's a good idea to match the predominant style of
existing code.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.