[Webkit-unassigned] [Bug 20393] Add WML support to WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20393





------- Comment #7 from sam at webkit.org  2008-08-19 10:27 PDT -------
(In reply to comment #6)
> I agree, but I think the concern is the parts that touch existing code.  The
> new files should also be fixed, but I believe the patch can go in and they can
> be fixed after.  It's quite a pain to work on this outside of svn.  It took
> days to merge to a point where it made sense to post the patch, and apparently
> there were even some monumental merge errors as mentioned by Mark.

While I understand the pain of working outside Trunk, I don't think it is a
good idea to commit even the new files without fixing obvious style issues and
other errors.  Since we don't expect this to be turned on in the mainline
WebKit (or at least I see no reason to), the code is more prone to bit rot due
to a lack of attention.

> 
> If the size of the patch is a concern, how about we check in the tests, then
> check in the wml/ directory, then post the rest for review?  It's totally
> harmless like that.
> 

This doesn't seem like the most ideal way to add it to the codebase, though
perhaps the easiest.  We certainly need to review the new files in the wml/
directory as well, and that will be easier if it is in chunks.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.