[Webkit-unassigned] [Bug 20350] [GTK] Get DumpRenderTree working

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20350


freyther at handhelds.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22835|review?                     |review+
               Flag|                            |




------- Comment #3 from freyther at handhelds.org  2008-08-17 06:16 PDT -------
(From update of attachment 22835)
Great step ahead.

You should get various new unused parameter warnings, e.g. just omit the
parameter name and you are fine.

The flushing should fix quite some issues.

The cosmetic changes are I fine and besides personal taste I could not find
anything in the Coding Style Guidelines to forbid comments at the end of the
line.

The removal of WorkQueue::shared()->clear() and addition of
webkit_web_view_open is something the other DRTs don't do. You are definitely
right that some results depend on the order of the tests...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.