[Webkit-unassigned] [Bug 20412] New: webkitview.cpp passes negative-value constants as guint

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20412

           Summary: webkitview.cpp passes negative-value constants as guint
           Product: WebKit
           Version: 526+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dmacks at netspace.org


Compiling webkit source (nightly r35788) on OS X 10.4, using all gtk and other
non-apple-supplied support libs using latest available from fink unstable
tree...

1. ./autogen.sh --prefix=/sw --with-target=x11 --with-http-backend=curl
--with-font-backend-pango --disable-video

no configure problems

2. make

WebKit/gtk/webkit/webkitwebview.cpp: In function 'void
webkit_web_view_init(WebKitWebView*)':
WebKit/gtk/webkit/webkitwebview.cpp:1431: warning: passing negative value
'WEBKIT_WEB_VIEW_TARGET_INFO_HTML' for argument 4 to 'void
gtk_target_list_add(GtkTargetList*, _GdkAtom*, guint, guint)'
WebKit/gtk/webkit/webkitwebview.cpp:1432: warning: passing negative value
'WEBKIT_WEB_VIEW_TARGET_INFO_TEXT' for argument 2 to 'void
gtk_target_list_add_text_targets(GtkTargetList*, guint)'
WebKit/gtk/webkit/webkitwebview.cpp:1436: warning: passing negative value
'WEBKIT_WEB_VIEW_TARGET_INFO_HTML' for argument 4 to 'void
gtk_target_list_add(GtkTargetList*, _GdkAtom*, guint, guint)'
WebKit/gtk/webkit/webkitwebview.cpp:1437: warning: passing negative value
'WEBKIT_WEB_VIEW_TARGET_INFO_TEXT' for argument 2 to 'void
gtk_target_list_add_text_targets(GtkTargetList*, guint)'

Sure enough, webkitwebview.h defines those constants as negative-values:

typedef enum
{
    WEBKIT_WEB_VIEW_TARGET_INFO_HTML = - 1,
    WEBKIT_WEB_VIEW_TARGET_INFO_TEXT = - 2
} WebKitWebViewTargetInfo;

I don't know how the gtk_lists themselves are used in gtk but the functions are
prototyped as guint in gtkselection.h (from gtk-2.12.11). The only other place
this value (appears to my casual reading) to be used is in
WebCore/platform/gtk/PasteboardGtk.cpp, where the stored token is casted to a
gint.

To a first guess, could just flip those enums to positive values?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.