[Webkit-unassigned] [Bug 20013] Windows AX huerusitics are poor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20013


jhoneycutt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22586|review?(jhoneycutt at apple.com|review-
               Flag|)                           |




------- Comment #55 from jhoneycutt at apple.com  2008-08-14 01:08 PDT -------
(From update of attachment 22586)
Looks like the changes related to children made it into your Name and Roles
patches; they should be removed from one of them.

         return WebAreaRole;
+    if (m_renderer->isTable())
Needs a new line before the if.

+    if(isListElement(node))
Missing a space between if and (.

When I use AccExplorer to look at Firefox 3's tree, label, abbr, acronym, and q
tags do not return ROLE_SYSTEM_GROUPING: label returns ROLE_SYSTEM_STATICTEXT,
acronym returns the string "acronym," abbr returns the string "abbr," and q
returns the string "q." I think you said you were testing Firefox 2, is that
right? Maybe this has changed in the newer version. I think we should try to
match Firefox 3.

Also, like the names patch, this patch changes the behavior of several
unrelated objects. I think you should split this into separate patches for each
object type: tables, lists, labels, etc.

r- for these reasons, but thanks for the patch! :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.