[Webkit-unassigned] [Bug 20263] [XBL] Add loading code for XBLBinding

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 12 17:12:26 PDT 2008


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #22758|review?                     |review+
               Flag|                            |

------- Comment #6 from eric at webkit.org  2008-08-12 17:12 PDT -------
(From update of attachment 22758)
+    int hasFragment = uri.find('#');

should probably be called fragmentOffset

This should be < 0:
(hasFragment != -1)

Sounds like we need a test case!
+    // FIXME: if no ID was given, the spec does not say what to do so for the
+    // do nothing for now.

There is a deleteAllValues() call you should use instead:
+        for (Vector<XBLBinding*>::iterator it = elementBindings->begin(); it
!= elementBindings->end(); ++it)
+            delete *it;

Otherwise looks OK to land with the above mentioned test case.   I don't need
to see this again, but you should make the above fixes/additional test case.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list