[Webkit-unassigned] [Bug 20347] [XBL] Add support for DocumentXBL interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20347


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22738|review?                     |review+
               Flag|                            |




------- Comment #2 from eric at webkit.org  2008-08-12 17:04 PDT -------
(From update of attachment 22738)
In general looks fine.  You should change the argument names attrName and name
to be documentURI where appropriate.

You really should be using the newer "fast/js" testing framework, with
shouldBe, etc.  There is TEMPLATE.html inside resources and
make-js-test-wrappers.

In general this looks fine.  I'd like to see you fix the tests to the new
system before landing.  Once you learn it, I think you'll find writing tests
are much easier (just ask WildFox). :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.