[Webkit-unassigned] [Bug 20340] SegmentedVector segment allocations can lead to unsafe use of temporary registers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20340





------- Comment #9 from cwzwarich at uwaterloo.ca  2008-08-11 19:54 PDT -------
(In reply to comment #8)
> Created an attachment (id=22729)
 --> (https://bugs.webkit.org/attachment.cgi?id=22729&action=view) [edit]
> Diff showing alternative fix
> 
> Attaching a diff showing an alternative fix.   Changes makeNewTemporary such
> that it never shrinks the SegmentedVector of RegisterID's.  The attached diff
> also contains a fix for a seperate bug.  The relevant changes for this bug are
> in CodeGenerator::makeNewTemporary and the various CodeGenerator constructors.

That's a decent idea. I don't really like the idea of doing it in an ad-hoc way
in CodeGenerator, so I'll modify SegmentedVector never shrink. Nothing ever
explicitly shrinks one in the current code.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.