[Webkit-unassigned] [Bug 20353] Use animation events to clear the highligted line effect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20353


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22739|review?(timothy at hatcher.name|review-
               Flag|)                           |




------- Comment #2 from timothy at hatcher.name  2008-08-11 19:02 PDT -------
(From update of attachment 22739)
+        // Timeout to reset any animation still running

Can you improve that comment? Something about coalesced style updates?

+        line.style.webkitAnimationName = 'none';

We also don't use single quote strings. I would prefer using setProperty fore
these.

 +        this.element.contentDocument.addEventListener("webkitAnimationEnd",
function (event) {
event.target.parentNode.removeStyleClass("webkit-highlighted-line");}, false);

Can you put the function on the prototype like _documentMouseDown.

+            line.style.webkitAnimationName = '';

That would make more sense as:

+             line.style.removeProperty("-webkit-animation-name")


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.