[Webkit-unassigned] [Bug 19939] [GTK] webkit_web_history_item_get_title() fails with assertion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19939


jmalonzo at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jmalonzo at gmail.com




------- Comment #3 from jmalonzo at gmail.com  2008-08-06 04:34 PDT -------
(In reply to comment #2)
> Created an attachment (id=22656)
 --> (https://bugs.webkit.org/attachment.cgi?id=22656&action=view) [edit]
> Fix history management
> 
> This patch fixes recently introduced regressions in WebHistory. Candidate for
> backporting to 1.0.1.
> 

@@ -257,9 +255,14 @@ WebKitWebHistoryItem* webkit_web_history
 {
     WebKitWebHistoryItem* webHistoryItem = kit(item);

-    if (!webHistoryItem) {
+    if (webHistoryItem)
+        g_object_ref(webHistoryItem);
+    else {

I don't think increasing the ref count is necessary here. The backforwardlist
already does that when it uses this function and there's no way to unref the
webHistoryItem when you do it here.

Looks good otherwise.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.