[Webkit-unassigned] [Bug 19794] [CURL] Crash if a local file has an unknow extension

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19794


marco.barisione at collabora.co.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marco.barisione at collabora.co
                   |                            |.uk
         AssignedTo|webkit-                     |marco.barisione at collabora.co
                   |unassigned at lists.webkit.org |.uk
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #5 from marco.barisione at collabora.co.uk  2008-08-06 03:59 PDT -------
I think that we have 3 different problems:

1. RegularExpression::match() should not pass a null string to jsRegExpExecute.
I opened a separate bug report for this, see bug #20295.

2. getMIMETypeForPath() returns "application/octet-stream" if there is not
extension but getMIMETypeForExtension() returns a null string. If don't like
this difference because it's confusing, but we have code that relies on that
and also the win port has the same behaviour but it doesn't crash as it doesn't
use the MIMETypeRegistry in this case. I don't know what the mac port does
because it calls a function without public source code. The qt port always
defaults to "application/octet-stream" so it's not affected by this problem.
The soup back-end uses a function in gio for this instead of the
MIMETypeRegistry, so it's not affected.
Unless someone (Alp?) thinks that changing getMIMETypeForExtension() to never
return a null string is the right behaviour I think that my previous patch is
useful, so I'm setting the review flag again

3. For now we don't have downloads in the GTK ports, so WebKit tries to show
also unknown mime types. Of course this is wrong but crashing in this case is
wronger :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.