[Webkit-unassigned] [Bug 20282] New: WebKitAvailability.h has Mac-specific versioning

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20282

           Summary: WebKitAvailability.h has Mac-specific versioning
           Product: WebKit
           Version: 526+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P1
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: alp at nuanti.com
                CC: ap at webkit.org, mrowe at apple.com, andersca at apple.com,
                    christian at imendio.com
OtherBugsDependingO 20232
             nThis:


The WebKitAvailability.h JavaScriptCore public API header file added WebKit/Mac
versioning to JavaScriptCore in r33053:

https://trac.webkit.org/changeset/33053?format=diff&new=33053

This specifies the following versions:

#define WEBKIT_VERSION_1_0    0x0100
#define WEBKIT_VERSION_1_1    0x0110
#define WEBKIT_VERSION_1_2    0x0120
#define WEBKIT_VERSION_1_3    0x0130
#define WEBKIT_VERSION_2_0    0x0200
#define WEBKIT_VERSION_3_0    0x0300
#define WEBKIT_VERSION_3_1    0x0310
#define WEBKIT_VERSION_LATEST 0x9999

Non-Apple ports of WebKit like the GTK+ port don't follow the same API
versioning scheme, so WebKit for GTK+ is currently on version 1.0.1 (stable)
and 1.0.2 (development) for example.

Encoding WebKit/Mac versioning in the portable JavaScriptCore API adds
unacceptable confusion, especially since the WebKit version numbers between
ports look very similar, so this is bound to cause confusion.

Additionally, there was no period of public review for this patch, which is a
little disappointing. We should have caught this issue before it ever landed.

+        <rdar://problem/4859666> WebKit needs availability macros in order to
deprecate APIs

There is already an appropriate bug report for this:

https://bugs.webkit.org/show_bug.cgi?id=20232

I suggest that we back this changeset out immediately before it starts getting
used by applications or ends up in a release.

Once this is done we can devise a separate API versioning scheme for
JavaScriptCore or find some other way of tying it in with toplevel WebKit API
versioning.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.