[Webkit-unassigned] [Bug 20020] Proposed enhancement to JavaScriptCore API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20020


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22643|review?                     |review-
               Flag|                            |




------- Comment #9 from sam at webkit.org  2008-08-04 19:28 PDT -------
(From update of attachment 22643)
The * should be on the other side for JSValueRef *exception.  There is also an
extra space.
+JSObjectRef JSObjectMakeArray(JSContextRef ctx, size_t argumentCount, const
JSValueRef arguments[],  JSValueRef *exception)

+JSObjectRef JSObjectMakeDate(JSContextRef ctx, size_t argumentCount, const
JSValueRef arguments[],  JSValueRef *exception)

+JSObjectRef JSObjectMakeDate(JSContextRef ctx, size_t argumentCount, const
JSValueRef arguments[],  JSValueRef *exception)

+JSObjectRef JSObjectMakeRegExp(JSContextRef ctx, size_t argumentCount, const
JSValueRef arguments[],  JSValueRef *exception)

Same here and few other places.
+    JSObject *result;


We like to use ++i where we can.  This issue exists in a number of  places.
+        for (size_t i = 0; i < argumentCount; i++)

The braces are not needed.
+    } else {
+        result = constructEmptyArray(exec);
+    }

It is 2008!  :)
+ * Copyright (C) 2007 Kelvin W Sherlock (ksherlock at gmail.com)

There are some uses of tabs that need to be removed.

You should also add some tests to the testapi.c test.

r-


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.