[Webkit-unassigned] [Bug 20253] A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20253





------- Comment #13 from zuh at iki.fi  2008-08-04 08:43 PDT -------
(In reply to comment #12)
> (From update of attachment 22621 [edit])
> >+   FLEX_VERSION=`$FLEX --version | sed 's,.*\ \([0-9]*\.[0-9]*\.[0-9]*\)$,\1,'`
> >+   AX_COMPARE_VERSION([2.5.33],[gt],[$FLEX_VERSION],
> >+      AC_MSG_ERROR([You need at least version 2.5.33 of the 'flex' lexer generator to compile WebKit]))
> > fi
> 
> Shouldn't that be "[ge]" since 2.5.33 works?

No, the statement is "if 2.5.33 is greater than $FLEX_VERSION, then
AC_MSG_ERROR, else do nothing" so anything starting from 2.5.33 goes to the
(omitted) false-branch and continues on.

One could change it around by adding an empty true-branch there:

AX_COMPARE_VERSION([2.5.33],[ge],[$FLEX_VERSION],,
  AC_MSG_ERROR([...]))

but that looks more like a typo then expected syntax... adding empty quotation
might help, but

AX_COMPARE_VERSION([2.5.33],[ge],[$FLEX_VERSION], [],
  AC_MSG_ERROR([...]))

doesn't look any better to me.

I can change it of course, if the positive test is deemed better.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.