[Webkit-unassigned] [Bug 19656] [SOUP] The gio code should call didFail() instead of didFinishLoading() in case of error

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19656


marco.barisione at collabora.co.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21819|0                           |1
        is obsolete|                            |
         AssignedTo|webkit-                     |marco.barisione at collabora.co
                   |unassigned at lists.webkit.org |.uk
             Status|NEW                         |ASSIGNED
  Attachment #22629|                            |review?
               Flag|                            |




------- Comment #3 from marco.barisione at collabora.co.uk  2008-08-04 04:45 PDT -------
Created an attachment (id=22629)
 --> (https://bugs.webkit.org/attachment.cgi?id=22629&action=view)
Call didFail in case of error

Adding something like GOwnPtr and GObjectPtr could be a good idea but it's
something for a separate patch.

"So we make 2 copies of the buffer just to send this URI off to ResourceError. 
Is it possible to avoid this?"

What do you mean? The copy from the GFile to a char and then to a String? In
this case I don't see any solution.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.