[Webkit-unassigned] [Bug 20221] [Qt] ToggleBold, ToggleItalic, and ToggleUnderline page actions should update during navigation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 4 02:50:09 PDT 2008


hausmann at webkit.org changed:

           What    |Removed                     |Added
  Attachment #22547|review?                     |review-
               Flag|                            |

------- Comment #3 from hausmann at webkit.org  2008-08-04 02:50 PDT -------
(From update of attachment 22547)
I agree with the patch in principle (thanks!), but there are a few minor
cosmetic glitches:

1) Please make the editorCommandWebActions array local to qwebpage.cpp by
prepending 'static'.

2) You commented out the cases for all the editor actions and handle it in
default: instead. That's fine, but I don't think we should leave the old code
commented out, please just remove it :)

3) The last item in the array should probably not end with a comma :)

r- because of those, but I'd be happy to r+ with them fixed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list