[Webkit-unassigned] [Bug 18665] HTMLTokenizer double allocates strings for <script>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18665


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21094|                            |review?
               Flag|                            |




------- Comment #10 from eric at webkit.org  2008-08-01 01:49 PDT -------
(From update of attachment 21094)
I assume he meant to mark this for review.

One style nit:
+    if (t->tagName == textAtom && t->text && current->localName() !=
scriptTag)
+    {

{ should be on the same line as the if in WebKit style.

Also, generally the changelog reads:
date/name line
blank
reviewed by line
blank
description and link to bug
blank
test cases (if applicable)
blank
comments on individual files.

The patch looks good to me, but I think someone else who has hacked in this
code recently should at least glance at it.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.