[Webkit-unassigned] [Bug 17971] [Curl] FormData processing should be moved to its own class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 30 23:22:19 PDT 2008


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #19904|review?                     |review-
               Flag|                            |

------- Comment #2 from eric at webkit.org  2008-04-30 23:22 PDT -------
(From update of attachment 19904)
Looks fine to me.  My only question was if the ownership was right for
ResourceHandle*, i.e. why is it safe to hold a weak pointer?  Using FILE*
directly kinda sucks too.  But I guess we don't have any nice C++ wrapper for

+    size_t toSend = size * nmemb;

integer overflow?  We really should have some sort of safe-multiply function.

What the heck does "nmemb" stand for?  A more clear variable name would be
helpful here.

You put * next to the argument name in at least two places.  This is in
violation of our style guidelines for C++:
+    size_t read(void *ptr, size_t size, size_t nmemb);

In general looks great.  I was going to r+ it,  but I think there are enough
little nits to warrent a second round.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list