[Webkit-unassigned] [Bug 18822] SQUIRRELFISH: incorrect eval used in some cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 30 23:07:24 PDT 2008


------- Comment #2 from cwzwarich at uwaterloo.ca  2008-04-30 23:07 PDT -------
This bug occurs because we don't create as many ExecStates as we used to. In
particular, the scope chain of the current ExecState in Machine::privateExecute
may not be the current scope chain. However, all
ExecState::lexicalGlobalObject() does is get the top of its ScopeChain, so we
should just replace the use of ExecState::lexicalGlobalObject() with
scopeChain->bottom() in op_call_eval.

This also means that other uses of ExecState::lexicalGlobalObject() are wrong
for cross-window function calls. Most of them are used for getting prototypes,
but there are others, e.g. setting up the scope chain in
FunctionObjectImp::construct(). We can't fix all of the others yet, because we
pass around an ExecState rather than a ScopeChainNode*.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list