[Webkit-unassigned] [Bug 11939] Quirksmode: Ignores media types in stylesheet PIs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 28 23:14:51 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=11939


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20847|review?                     |review+
               Flag|                            |




------- Comment #8 from eric at webkit.org  2008-04-28 23:14 PDT -------
(From update of attachment 20847)
Great!  r=me.  However, I would prefer that you fix setMedia to take a
PassRefPtr while you're in that code.  It takes a raw ptr, but does take
ownership of it (so your code doesn't leak) but at first glance it looks like
it does.  setMedia pre-dates PassRefPtr I think.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list