[Webkit-unassigned] [Bug 18550] cross-frame-access-call.html doesn't really test window.open(), since popups are blocked

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18550


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20673|review?                     |review+
               Flag|                            |




------- Comment #4 from aroben at apple.com  2008-04-27 22:27 PDT -------
(From update of attachment 20673)
+2008-04-18  Eric Roman  <minatoar at gmail.com>
+
+        Reviewed by NOBODY (OOPS!).
+
+        * http/tests/security/cross-frame-access-call-expected.txt: Increase a
console line number (since added two lines)
+        * http/tests/security/cross-frame-access-call.html: Enable popups for
this layout test. The test checks that window.open is returns undefined
(same-domain enforcement), however unless popups are enabled it returns
undefined regardless.
+

It's customary to list the bug title and URL of the bug you're fixing in your
ChangeLog entry (though I think unfortunately this is not mentioned on our
website anywhere). Whomever lands this patch can add that for you.

r=me. Thanks!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.