[Webkit-unassigned] [Bug 18773] Crash in JSInspectedObjectWrapper::prepareIncomingValue using Web Inspector on Socialiser Modification for IPB

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18773





------- Comment #3 from aroben at apple.com  2008-04-27 19:52 PDT -------
We're crashing when calling getAttribute on a node from the inspected page:

var idAttribute = current.getAttribute("id");

<http://trac.webkit.org/browser/trunk/WebCore/page/inspector/ElementsPanel.js#L382>

The assertion is happening when trying to prepare the "this" object (i.e.,
`current`). It looks like we've just traversed from one frame to another via
_parentNodeOrFrameElement, and the wrappers are not handling this case
correctly. The message in the assertion is misleading in this case; we are in
fact passing a wrapped object (i.e., `current` is in fact wrapped), but the
wrapped object has a different global object from the one we were expecting.

I think we can take 3 actions in response to this:
1. Make the wrappers able to handle this frame traversal (which should fix the
assertion).
2. Return jsUndefined() instead of 0 from prepareIncomingValue when we hit an
unexpected condition so that we will throw a JS exception instead of crashing.
3. Make the assertion message clearer about what's happening in this case.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.