[Webkit-unassigned] [Bug 18746] SQUIRRELFISH: indirect eval used when direct eval should be used

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18746





------- Comment #5 from cwzwarich at uwaterloo.ca  2008-04-25 23:27 PDT -------
Changing the direct eval check to

if (base == exec->globalThisValue() && v ==
exec->lexicalGlobalObject()->evalFunction()) {

fixes almost all of the eval tests. The only exceptions, which it changes from
passing to failing, are tests of the form

(function() { var eval = window.eval; return eval("var y; "y" in window"); })()

Here, op_call_eval is emitted for the eval, and the new direct eval check
erroneously returns that it is a direct eval. Since this is the same test used
for direct eval on trunk with the split window patch, it seems the best way to
fix this is to get the split window patch fully functional on SquirrelFish.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.