[Webkit-unassigned] [Bug 14750] [gtk] Implement plugin support in GTK backend

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14750


hausmann at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hausmann at webkit.org




------- Comment #69 from hausmann at webkit.org  2008-04-23 06:41 PDT -------
First of all, great job!!

I have a few small comments:

+#elif PLATFORM(QT) && PLATFORM(UNIX)
+#define ENABLE_NETSCAPE_PLUGIN_API 1

In order to not break the Qt/Mac and the Qt/Embedded build I suggest to make
this even stricter by perhaps simply using

#elif PLATFORM(QT) && defined(Q_WS_X11)


In PluginPackageQt.cpp, PluginPackage::load() if loading the module fails I
think the QLibrary should be deleted and m_module be set back to a null
pointer. Also it seems that unloadModule() in FileSystemQt.cpp does not delete
the QLibrary itself, it just calls unload(), which it seems the caller in
PluginPackage::freeLibraryTimerFired() expects the function to free any
allocated resources.

In PluginViewQt.cpp in the PluginView destructor:
+    if (m_window)
+        delete m_window;

I think the if() is safe to remove :)

Other than that I looks good to me on the Qt side.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.