[Webkit-unassigned] [Bug 18281] [GTK] add functions to set/get the zoom level

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18281





------- Comment #13 from christian at imendio.com  2008-04-21 23:11 PDT -------
(From update of attachment 20475)
>+static const gfloat minimumZoomMultiplier = 0.5f;
>+static const gfloat maximumZoomMultiplier = 3.0f;
>+static const gfloat zoomMultiplierRatio = 1.2f;

I still think these should be exposed in the API. For the sake of this bug I
would be willing to add them to WebKitWebSettings myself, after this is landed.

>@@ -95,7 +102,9 @@ enum {
>     PROP_PASTE_TARGET_LIST,
>     PROP_EDITABLE,
>     PROP_SETTINGS,
>-    PROP_TRANSPARENT
>+    PROP_TRANSPARENT,
>+    PROP_ZOOM_LEVEL,
>+    PROP_TEXT_ONLY_ZOOM

As for "text-only-zoom" I have two questions:

1. What about calling this "zoom-text-only", to have it align visually with
"zoom-level"?

2. Would it make more sense to move this property to WebKitWebSettings? I do
not know the answer myself. If anyone has an actual use case I would most
appreciate that.

>+    g_object_class_install_property(objectClass, PROP_ZOOM_LEVEL,
>+                                    g_param_spec_float("zoom-level",
>+                                                       "Zoom level",
>+                                                       "The level of zoom of the content",
>+                                                       G_MINFLOAT,
>+                                                       G_MAXFLOAT,
>+                                                       1,
>+                                                       WEBKIT_PARAM_READWRITE));

This is not your fault. But I'm wondering why WebView has a different style
when it comes to property installation. I was certainly tempted to criticize
you for that =)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.