[Webkit-unassigned] [Bug 18665] HTMLTokenizer double allocates strings for <script>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 21 15:11:23 PDT 2008


------- Comment #3 from eric at webkit.org  2008-04-21 15:11 PDT -------
(From update of attachment 20738)
We don't generally use PassRefPtr<> on the stack, rather we use RefPtr<> and
call .release() on the ref ptr (to make it more explicit that you're clearing

This patch changes two behaviors.

1.  The string passed off into JSC now has all nulls removed.  I'm not sure
what we would actually do when encoutering a null char in a script?  I assume
that's an error, in which case scripts will now succeed which would previously

2. Under what circumstances can processToken() return 0?  You've changed the
behavior.  Before we would have passed a non-empty string off to JSC, where as
now we'll pass an empty string in that case.

In general the patch looks good, and the idea is sound, but we should answer
these minor details before landing this.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list