[Webkit-unassigned] [Bug 13596] Implement .onprogress handler on XMLHttpRequest objects to support progressive download content length information

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13596


julien.chaffraix at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20722|                            |review?
               Flag|                            |




------- Comment #11 from julien.chaffraix at gmail.com  2008-04-21 06:41 PDT -------
Created an attachment (id=20722)
 --> (http://bugs.webkit.org/attachment.cgi?id=20722&action=view)
Updated with Ap's latest comments

> I think that we need to support adding handlers via addEventListener, not just
> .onprogress.

As mentioned on IRC, we can can register those handlers but they were not
called because of an error on my side (forgotten to call dispatchEvent). Should
be corrected.

> I have noticed that the spec actually describes when the event should be fired:
>"every 350ms (+-200ms) or for every byte received, whichever is least
> frequent." I think it's OK to land a first version as is, to improve on this
> later.

I had not seen that. 

> +        // XmlHttpRequest 2 extension
> Should be "XMLHttpRequest".

Corrected.

> What is wrong with returning m_loaded?

I had to check Firefox behaviour first: there was some mention of giving
special value if computableLength was false and I thought it could apply here
too. I have check and we match Firefox so removed the 2 comments.

> Should be progressEvent to avoid constructing an AtomicString from "progress"
> again and again.

Corrected too.

I only included a "proof of concept" test case and some of your comments ask
for more of them. I will bundle more and have them landed later to have a
broader regression test suite (the patch is big enough without them ;)).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.