[Webkit-unassigned] [Bug 18634] SQUIRRELFISH: correctly handle variable and function declarations in eval code

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18634


cwzwarich at uwaterloo.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20716|0                           |1
        is obsolete|                            |
  Attachment #20718|                            |review?
               Flag|                            |




------- Comment #5 from cwzwarich at uwaterloo.ca  2008-04-21 00:32 PDT -------
Created an attachment (id=20718)
 --> (http://bugs.webkit.org/attachment.cgi?id=20718&action=view)
Revised proposed patch

It turns out that the cause of the speedup was a GC bug in string-tagcloud,
where the EvalCodeBlocks were not getting marked. Here is a patch that fixes
the GC bug by treating EvalCodeBlocks like ProgramCodeBlocks. This time there
is no difference on SunSpider.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.