[Webkit-unassigned] [Bug 18428] Patch to support building wxWebKit on mingw

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18428





------- Comment #11 from kevino at theolliviers.com  2008-04-20 16:03 PDT -------
(In reply to comment #10)
> Yes, I think this is the best way - to use a compiler specific check. I just
> tried to follow the advice in Comment #7 about the mingw ifdefs.
> 
> As for the conditions in the bakefiles, I was just cautious with the bakefile
> syntax, was as a precaution to be sure the logical operator precedence is as I
> want it, some sort of defensive programming :) Ok so I will remove the braces
> 
> Echo statements removed in the updated patch from Comment #8
> 
> About the static version - I think I experienced exactly what you mean, but the
> conflict happens (at least on windows) when I try to link with a static version
> of wxWidgets. If I make a static build of wxWebkit that uses a shared version
> of wxWidgets, there is no problem at all - at link time the linker sees only
> wxWebkit's libjpeg and libpng, not the builtin in the wxWidgets shared libs.
> But this is on windows and mingw. If this is not the case with other platforms,
> then ok, I remove the static build. But I am writing this just to be sure we
> are meaning the same thing by "static build".
> 

Right, this is not the case on other platforms, and I didn't want to cause
confusion about what combinations can be supported. The issue can be fixed now
that gcc has added visibility support in  4.0, but wxWidgets did not add
support for building with visibility flags until 2.9, which is not in a good
enough state to be used for wxWebKit development yet. :( So to fix this for
real we'd have to either backport the 2.9 visibility handling to 2.8 or
implement image loading so that it uses wx APIs rather than libpng directly,
which may be difficult as I'm not sure wx's image classes are good at handling
data being streamed in.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.