[Webkit-unassigned] [Bug 18512] getPresentationAttribute returns a shared object

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18512


rwlbuis at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20694|                            |review?
               Flag|                            |




------- Comment #7 from rwlbuis at gmail.com  2008-04-20 00:54 PDT -------
Created an attachment (id=20694)
 --> (http://bugs.webkit.org/attachment.cgi?id=20694&action=view)
First attempt

This small patch fixes the problem. However I wonder if there is a nicer way to
do it. I guess there is nothing wrong with sharing the style declaration for
this attribute though, since in the testcase the values are equal and we do not
know up front that we are going to use getPresentationAttribute, which is used
very rarely anyway. So I really can't see another way, though maybe the
unsharing can be done with less statements or some helper method in
StyledElement. I'll do the testcase later, I think the original testcase in the
bug is a good base for an automated test.
Cheers,

Rob.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.