[Webkit-unassigned] [Bug 17331] Change postMessage/MessageEvent to match HTML5 wrt. exposing origin vs. domain/uri

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 18 10:05:57 PDT 2008


aroben at apple.com changed:

           What    |Removed                     |Added
  Attachment #20631|review?                     |review+
               Flag|                            |

------- Comment #36 from aroben at apple.com  2008-04-18 10:05 PDT -------
(From update of attachment 20631)
r31975 added protocolHostAndPortAreEqual to KURL.h. Should we use that instead
of adding SecurityOrigin::isSameSchemeHostPort?

+    // Sender is not allowed to see exceptions other than syntax errors
+    ExceptionCode ec; 
+    document()->dispatchEvent(new MessageEvent(message, sourceOrigin, source),
ec, true);

Should ec be initialized to 0?

+        [DoNotCheckDomainSecurity, Custom] void postMessage(in DOMString
message, in [Optional] DOMString origin)

Let's call it targetOrigin here as well.

+    if (m_port) {
+      append(result, ":");
+      append(result, String::number(m_port));
+    }

Looks like the indentation got messed up here.

+        // Okay deleted value because "invalid-protocol" is not a valid

What makes it invalid?

You should use svn cp when renaming the tests so that the history is preserved
(maybe  you already did this and it didn't come through in the diff).

r=me, but feel free to fix the above. You may also want to get Sam Weinig to
give this a quick once-over before landing.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list