[Webkit-unassigned] [Bug 18357] [GTK] Enter on buttons doesn't work

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18357


alp at atoker.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alp at atoker.com,
                   |                            |ap at webkit.org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #2 from alp at atoker.com  2008-04-17 17:22 PDT -------
(In reply to comment #1)
> Created an attachment (id=20402)
 --> (http://bugs.webkit.org/attachment.cgi?id=20402&action=view) [edit]
> Set the text of the event to '\r' when the return/enter key is pressed
> 
> Note that I used '\r' instead of '\n' because it's what WebCore use. Probably
> it's better to use '\n' modifying WebCore to allow this, but I think there
> could be a lot of places in WebCore where the code assumes that enter is '\r'.
> What do you think?
> 

Yeah. While this fix looks like it'll work I think it'd be great to investigate
if this can be fixed better in WebCore.

Marco: It's up to you. I can land this patch if you're willing to follow it up
with a proper fix (if necessary), or I can leave it out till we get a better
idea of how to proceed. It might be worth talking with ap (Alexey) about this
one, he has a good eye for input issues.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.