[Webkit-unassigned] [Bug 18518] Implement eval in SquirrelFish

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 17 09:53:44 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=18518


ggaren at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20616|0                           |1
        is obsolete|                            |
  Attachment #20630|                            |review?
               Flag|                            |




------- Comment #21 from ggaren at apple.com  2008-04-17 09:53 PDT -------
Created an attachment (id=20630)
 --> (http://bugs.webkit.org/attachment.cgi?id=20630&action=view)
patch

Since the patch worked for Cameron, I think I'll put it up for review.

New changes in this version: Fixed exception propagation from "this.eval".
Changed eval codegen to use resolve_base_and_func instead of
resolve_base_and_property, so "this" is right if eval is declared as a local in
a function. Renamed emitEval to emitCallEval, to match the earlier opcode
rename I did. 


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list